-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adds receive_message test #11
Conversation
blocks were used from flat files decoder, which means it is no longer coupled to this dependency. Also commented functions that will be moved to flat_head
…ords and Header from portalapi
I just opened an issue on Ethportal api, to add |
adds optional lockfile usage, helps testing
…oder without using wrappers sf-protos contains the dependencies from the proto files that are used both in the header accumulator and flat files decoder. This means that both of them can share a single instance of a type without implementing try_from conversions or similar
…ecords-function): extract_100_blocks is not necessary in header acc anymore, since block handling is now done by flat files decoder. ext_header_from_block now hande singular blocks and should be used inside a .map() for conversion of Block arrays
…ion and generation after refactor
flat-files decoder is now only used in tests to facilitate validating header_accumulator functions
Basically, I've used sf-protos to interchange types between header_accumulator and flat-files-decoder without having to rely on external crates conversions. Before merging, I will make sure that the |
…exists as a From trait implementation
From here onwards, most commits are tests to attempt to achieve at least 80% coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few minor changes requested.
… warns against post-merge blocks
Some more things had to be refactored in order to remove
flat-files-decoder
entirely from this crate. This will be merged intorefactor
branch because it is a specific part of era_validate that needs to be validate in the other 2 repos before merging, so having a new branch specifically for this helps in that.